fix: prevent delegate tool from bypassing user permission denial #3302
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delegate tool was not properly checking user approval responses. When get_user_confirmation() returned Ok(false) (user declined), the ? operator would not trigger an error, allowing delegation to proceed despite user denial. This fix explicitly checks the boolean return value and returns an error when the user declines, preventing unauthorized delegation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegate tool was not properly checking user approval responses. When get_user_confirmation() returned Ok(false) (user declined), the ? operator would not trigger an error, allowing delegation to proceed despite user denial.
This fix explicitly checks the boolean return value and returns an error when the user declines, preventing unauthorized delegation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.